Enhance filtering capabilities#204
Merged
phillip-wenig-frequenz merged 3 commits intoOct 29, 2025
Merged
Conversation
github-actions
Bot
added
part:docs
- Add `tag` parameter to `gridpool_trades()` method for filtering trades by tag - Update `GridpoolTradeFilter` dataclass to include `tag` field - Update equality and hash methods to include tag field - Update `from_pb()` and `to_pb()` methods to handle tag serialization - Bump frequenz-api-electricity-trading dependency to 0.9.0 - Update import path for PaginationParams to v1alpha8 Signed-off-by: Phillip Wenig <phillip.wenig@frequenz.com>
phillip-wenig-frequenz
force-pushed
the
add-tag-filter
branch
from
474db3c to
9445508
Compare
florian-wagner-frequenz
previously approved these changes
Oct 28, 2025
Contributor
florian-wagner-frequenz
left a comment
florian-wagner-frequenz
left a comment
There was a problem hiding this comment.
LGTM, just some minor nits you might want to consider.
phillip-wenig-frequenz
force-pushed
the
add-tag-filter
branch
from
9445508 to
55b5096
Compare
florian-wagner-frequenz
previously approved these changes
Oct 29, 2025
Contributor
florian-wagner-frequenz
left a comment
florian-wagner-frequenz
left a comment
There was a problem hiding this comment.
LGTM, seems you missed some spots for the doc-string refinement, but I don't think that's blocking.
| trade_ids: List of trade IDs to filter for. | ||
| market_side: The market side to filter for. | ||
| delivery_period: The delivery period to filter for. | ||
| delivery_time_filter: The delivery time to filter for. |
Contributor
There was a problem hiding this comment.
Nit: one place you missed
Contributor
There was a problem hiding this comment.
It seems you missed some more. I prefer the phrasing from line 844, as the time filter is more than just the time(span), but also includes the time granularity.
But it's completely optional.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
…iltering This change updates the filtering mechanism for gridpool orders and trades to use a more flexible `DeliveryTimeFilter` instead of the restrictive `DeliveryPeriod`. The new filter supports: - Time interval filtering with optional start/end times - Multiple delivery duration filters - More granular control over time-based queries Key changes: - Added `Interval` and `DeliveryTimeFilter` types to support the new filtering API - Replaced `delivery_period` parameter with `delivery_time_filter` across all client methods - Updated CLI to construct `DeliveryTimeFilter` from delivery_start parameter - Migrated tests to use the new filtering types - Updated API imports from v1 to v1alpha8 for common types - Removed dependency on frequenz.client.common.pagination in favor of direct protobuf usage This change maintains backward compatibility by keeping the `delivery_period` parameter in the `create_gridpool_order` method while adding the new `delivery_time_filter` parameter. Signed-off-by: Phillip Wenig <phillip.wenig@frequenz.com>
Signed-off-by: Phillip Wenig <phillip.wenig@frequenz.com>
phillip-wenig-frequenz
force-pushed
the
add-tag-filter
branch
from
55b5096 to
5913665
Compare
Contributor
Author
|
Updated the missed doc string and bumped the |
Contributor
|
Thanks @phillip-wenig-frequenz and @florian-wagner-frequenz for taking care! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag filtering for gridpool trades: The
gridpool_trades()method now accepts atagparameter to filter trades by tag. TheGridpoolTradeFilterdataclass has been updated accordingly.Flexible time filtering with
DeliveryTimeFilter: Replaced the restrictivedelivery_periodparameter with a more flexibledelivery_time_filteracross gridpool orders and trades methods. The newDeliveryTimeFiltersupports:New types for time filtering: Added
IntervalandDeliveryTimeFiltertypes to support the enhanced filtering API.